Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix phpdoc types for $_query in CRM_Core_Selector_Base subclasses #22424

Merged
merged 1 commit into from
Jan 8, 2022

Conversation

braders
Copy link
Contributor

@braders braders commented Jan 8, 2022

Overview

Fix phpdoc types for $_query in CRM_Core_Selector_Base subclasses

Before

$_query variable incorrectly declared as string in various classes, all of which extended CRM_Core_Selector_Base.

After

$_query variable correctly documented as CRM_Contact_BAO_Query. As the CRM_Core_Selector_Base objects are not namespaced, leading \ removed from type for consistency in a handful of cases.

@civibot
Copy link

civibot bot commented Jan 8, 2022

(Standard links)

@civibot civibot bot added the master label Jan 8, 2022
@colemanw colemanw merged commit 1efbaae into civicrm:master Jan 8, 2022
@colemanw
Copy link
Member

colemanw commented Jan 8, 2022

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants