Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIv4 - Set 'activity_type_id' to required #22359

Merged
merged 1 commit into from
Jan 3, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jan 3, 2022

Overview

In APIv4 GetFields, sets activity_type_id because it is in fact needed to create an activity.

Before

Field not required, but should be.

After

Required.

Technical Details

The database default '1' is problematic as the option list is user-configurable, so activity type '1' doesn't necessarily exist.

In APIv4 GetFields, sets activity field to required because the
database default is problematic.
@civibot
Copy link

civibot bot commented Jan 3, 2022

(Standard links)

@eileenmcnaughton
Copy link
Contributor

Why on earth would THIS be the field where we use a db default rather than required. Could make the case for a schema change here!

@eileenmcnaughton eileenmcnaughton merged commit 1793196 into civicrm:master Jan 3, 2022
@eileenmcnaughton eileenmcnaughton deleted the api4ActivityCreate branch January 3, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants