dev/drupal#172 - module status used incorrectly in drupal 8 to determine which modules to care about for managed entities

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/drupal/-/issues/172

See also conversation at #22337 (comment)

Before

Includes ALL non-core modules, and then indicates disabled status by incorrectly using the installation status. (In drupal 8 there is no such thing as disabled - "Do or do not - there is no try".)

After

Only includes installed modules, and then indicate enabled, since installed and enabled are the same in drupal 8.

Technical Details

This makes it more like the drupal 7 version

civicrm-core/CRM/Utils/System/DrupalBase.php

Lines 296 to 298 in 29cc02c

	$q = db_query('SELECT name, status FROM {system} WHERE type = \'module\' AND schema_version <> -1');
	foreach ($q as $row) {
	$result[] = new CRM_Core_Module('drupal.' . $row->name, $row->status == 1);

, i.e.

Drupal 7: schema_version <> -1 means installed, status == 1 means enabled
Drupal 8: status == 1 means installed (and implicitly then enabled), status == 0 means uninstalled. Schema version not relevant.

Comments

You'll notice line 557 is unused. That's what #22337 is about.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@demeritcowboy needs a rebase

[seamuslee001]

Jenkins re test this please

[colemanw]

Makes sense, thanks @demeritcowboy for figuring that out.