[REF] move code into the function

[eileenmcnaughton]

Overview

[REF] move code into the function

Before

Membership processing starts in the main function & continues in doMembershipProcessing

After

It's all in doMembershipProcessing

Technical Details

Within the if there is some code & then a function call. There doesn't seem
to be much reason for some of the code to be in the function & some
outside - this simplifies

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).