Fix testMultipleMembershipsContribution to use order api #22274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
mems
branch
from
b732f10 to
6872f14
Compare
|
@colemanw can I get a merge on this? |
|
@colemanw @seamuslee001 @demeritcowboy this should be a straight forward merge - unlike the stalled one it does not have a date change in it |
| $this->assertEquals($result1['contact_id'], $contactId1); | ||
| $this->assertEquals($result1['status_id'], $newMembershipId); | ||
| $this->assertEquals($contactId1, $memberships[0]['contact_id']); | ||
| $this->assertEquals('test status', CRM_Core_PseudoConstant::getName('CRM_Member_BAO_Membership', 'status_id', $memberships[0]['status_id'], 'New')); |
There was a problem hiding this comment.
I think this PR is ok but the 'New' was confusing me, but it seems getName() only takes 3 params so the New does nothing. Was it meant to check that the membership is in a New state?
There was a problem hiding this comment.
Good catch. Can you fix this @eileenmcnaughton and then it can be MOP.
There was a problem hiding this comment.
@colemanw @demeritcowboy fixed - thanks!
This test was not creating valid financial records prior to this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was not creating valid financial records prior to this