Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/mixin/bin/test-all - Fix guard for EXT_DIR #22204

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

totten
Copy link
Member

@totten totten commented Dec 2, 2021

Overview

This patches a test/infra script and does not affect runtime functionality.

Follow-up to #22198. CC @seamuslee001

Before

tools/mixin/bin/test-all only runs if there is a pre-existing copy of the example extension ($extensionsDir/example-mixin). If you attempt to run on a clean build (where there is no example extension yet), then it complains that the directory does not exist.

After

tools/mixin/bin/test-all only asserts that the $extensionsDir exists. It auto-creates $extensionsDir/example-mixin as needed.

There are two slightly different dirs - the example-extension and the extension-container (ie child-dir and parent-dir).
We want to assert that the parent-dir is well-formed, but then use the child-dir.
@civibot
Copy link

civibot bot commented Dec 2, 2021

(Standard links)

@totten
Copy link
Member Author

totten commented Dec 2, 2021

Test failure is unrelated.

@totten totten merged commit 1d041a1 into civicrm:master Dec 2, 2021
@totten totten deleted the master-mixin-testall branch December 2, 2021 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants