Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Smarty variables] Fix contribution tab to work with escape by default #22179

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

This removes some isset that affect contact contribution tab if escape on output is enabled.

Before

Fatal on contribution (if they have contributions) with modifiers enabled by default

After

loads

Technical Details

This might regress some smarty e-notices. I think if tests pass that is OK at this stage
as we never eliminted them & getting to security enablable seems like a higher priority

Comments

@civibot
Copy link

civibot bot commented Nov 30, 2021

(Standard links)

@civibot civibot bot added the master label Nov 30, 2021
This removes some isset that affect contact contribution tab if escape on output is enabled.

This might regress some smarty e-notices. I think if tests pass that is OK at this stage
as we never eliminted them & getting to security enablable seems like a higher priority
@eileenmcnaughton eileenmcnaughton changed the title Fix contribution tab to work with escape by default [Smarty variables] Fix contribution tab to work with escape by default Dec 1, 2021
@eileenmcnaughton
Copy link
Contributor Author

unrelated fail (date specific - failing elsewhere)

@eileenmcnaughton eileenmcnaughton merged commit f39b93b into civicrm:master Dec 1, 2021
@eileenmcnaughton eileenmcnaughton deleted the smarty6 branch December 1, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants