dev/mail#105 - Oauth dropdown missing on mail settings form

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/mail/-/issues/105

https://civicrm.stackexchange.com/questions/40773/cant-add-gmail-account-with-oauth

On the mail accounts page, there's supposed to be a dropdown in place of the usual Add button.

Before

1. Enable Oauth-client extension.
2. Set up gmail.
3. Go to the mail accounts page.
4. There isn't a dropdown to select gmail.

After

Ok

Technical Details

Looks like 60a6221

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[seamuslee001]

@colemanw

[seamuslee001]

Jenkins re test this please

[colemanw]

Yea, APIv4 has gotten stricter about what it will output, the default return value is now restricted to declared fields. IMO that's a step up from APIv3's standard of "whatever" but enforcing it has surfaced a few oopsies in the getfields.

[demeritcowboy]

Thanks!

[colemanw]

Made a note in the APIv4 changelog: https://lab.civicrm.org/documentation/docs/dev/-/blob/master/docs/api/v4/changes.md#543-only-fields-declared-in-getfields-returned-by-default