SearchKit - enable search by case role

[colemanw]

Overview

Permits searching for contacts by case role in SearchKit.

Technical Details

Required heavy refactoring of the APIv4 EntityBridge code to permit asymmetric bridges and bridges to multiple entities.

Comments

In order to feel safe about this refactor I added a bunch of test coverage.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Retest this please

[kurund]

@colemanw

Overall working fine and the use case mentioned is working fine. Noticed minor glitch.

Duplicate contacts are listed. However, grouping by contact id does fix it. I think this might have been always this way.

Tested few other searches and refactoring didn't have regressions.

[colemanw]

@kurund that's because without specific relationship types specified, it is returning both sides of each relationship - in the screenshot, Alida Adams is clearly the case client, so is getting returned as the "B" side of each relationship. Adding an ON clause could filter those out.

[Guydn]

I have CiviCRM 5.44 and Compucorp Case extension 2.4.0 (last one). I use a lot Civicase.
The PR was implemented.
I tried to build one search (from contact) and I was not able to see the new entities (contact case roles).

Then I realise that Searches with cases (dossier in French) were broken, see screenshots. Maybe I should have done some technical action (caches, database action, ...) .... See screenshots with searches with the PR.

The PR was rolled back immediately.

[kurund]

@colemanw

Okie that makes sense. Good to merge IMO

[kurund]

@Guydn

Do you mean you are running the master branch? Can you check without the case extension to rule out potential issues with the extension?

[Guydn]

I have just tried another time. Caches were cleaned.
It works, as you can see I the screenshot. I do get the report with case and case coordinator :-).

I saw this time the new entities case client case contact roles.
The previous searches are ok.
However I have lost all the forms, related my previous searches, whatever the search is.

[colemanw]

Thanks for retesting this @Guydn. I think the issue you experienced with missing forms is unrelated to this PR, as this doesn't touch any form code.