Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not smarty encode quicksearch html #22033

Merged
merged 1 commit into from
Nov 11, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Nov 10, 2021

Overview

Do not smarty encode quicksearch html

Before

Quicksearch fields with quotes escaped when default modifiers are on

After

Fields not escaped when default modifiers are on

Technical Details

I don't really get the need for these fields to be json-encoded but it seems 'legit'

Comments

@civibot
Copy link

civibot bot commented Nov 10, 2021

(Standard links)

@civibot civibot bot added the master label Nov 10, 2021
@colemanw
Copy link
Member

This is in line with our discussions about phasing in smarty escaping and preemptively marking certain variables as not-to-be-escaped.

@eileenmcnaughton eileenmcnaughton merged commit 774ccb0 into civicrm:master Nov 11, 2021
@eileenmcnaughton eileenmcnaughton deleted the quick branch November 11, 2021 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants