Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/report#77 - Unused variable in contribute/history civireport #22016

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

demeritcowboy
Copy link
Contributor

@demeritcowboy demeritcowboy commented Nov 9, 2021

Overview

E_NOTICE for $entryFound.

This is the contribution aggregrate by relationship report (called History.php of course).

There are a lot of smarty notices on this page - this is a regular old E_NOTICE.

Before

E_NOTICE

After

Unused variable removed

Technical Details

This variable is used in other reports to skip looping over all the rows when the first row doesn't contain any of the columns you're altering. That's not desirable here anyway because of the inner loop higher up that potentially could run on every row. In any case this is no change from current since the variable is never checked.

Comments

@civibot
Copy link

civibot bot commented Nov 9, 2021

(Standard links)

@civibot civibot bot added the master label Nov 9, 2021
@seamuslee001 seamuslee001 merged commit 3f1184d into civicrm:master Nov 10, 2021
@demeritcowboy demeritcowboy deleted the histreport-entryfound branch November 10, 2021 01:47
@demeritcowboy
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants