dev/report#77 - Unused variable in contribute/history civireport #22016
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
E_NOTICE for
$entryFound
.This is the contribution aggregrate by relationship report (called History.php of course).
There are a lot of smarty notices on this page - this is a regular old E_NOTICE.
Before
E_NOTICE
After
Unused variable removed
Technical Details
This variable is used in other reports to skip looping over all the rows when the first row doesn't contain any of the columns you're altering. That's not desirable here anyway because of the inner loop higher up that potentially could run on every row. In any case this is no change from current since the variable is never checked.
Comments