Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unencoded mailing url query param in Mailing report #22008

Conversation

artfulrobot
Copy link
Contributor

Overview

The mailing report generated invalid URLs which broke the report that lists all clicks on a certain tracked link.

Before

The report constructed URLs containing clicked URLs without encoding them, breaking the original URL.

After

Encoding is applied. The report links work.

Comments

Found links where the clicked URL contained a fragment identifier # completely broke the URL generated.

@civibot
Copy link

civibot bot commented Nov 8, 2021

(Standard links)

@civibot civibot bot added the master label Nov 8, 2021
@seamuslee001
Copy link
Contributor

This seems fine to me merging

@seamuslee001 seamuslee001 merged commit dff817e into civicrm:master Nov 9, 2021
@artfulrobot
Copy link
Contributor Author

Thanks @seamuslee001 for reviewing, merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants