[REF] Remove usage of deprecated jqXHR.error in jQuery code

[braders]

Overview

jqXHR.error is deprecated in jQuery 1.8 and removed in jQuery 3.

This update replaces usage of jqXHR.error with the correct jqXHR.fail. (jqXHR refers to the promise interface returned by calls to $.ajax() and $.post())

Before

CiviCRM was using deprecated jQuery methods, which have been removed from jQuery 3.

After

CiviCRM is no longer using the deprecated jqXHR.error method.

Comments

See https://api.jquery.com/jQuery.ajax/#jqXHR for details of the deprecation. CiviCRM appears to currently be using jQuery 1.12.4 which will support the jqXHR.fail method.

Although CiviCRM does not use the host CMS's version of jQuery by default, extensions like https://civicrm.org/extensions/civi-jquery do allow CiviCRM to work in this way. This change will help avoid problems if sites attempt to run CiviCRM with their host CMS' version of jQuery and the host CMS is using jQuery 3.

Longer-term this will be a step towards making it feasable for CiviCRM to upgrade to jQuery 3.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Thanks @braders - the code change looks good to me. Can you give steps for how one would manually test test this on a demo site or local build?

[braders]

Thanks @braders - the code change looks good to me. Can you give steps for how one would manually test test this on a demo site or local build?

Good question. The easist way to trigger the .fail callback to run is to disconnect network connectivity when the AJAX request is done. You can do this by emulating offline mode from the network tab of your browser's devtools (assuming a Chromium-based or Firefox browser). Alternatively turn off wifi and/or pull out your computers internet cable!

To trigger the API call in templates/CRM/Financial/Form/Search.tpl, go to the "Accounting Batches" (civicrm/financial/financialbatches) page, select a batch and from the " - actions - " dropdown either close or re-open the batch. The AJAX call runs when you click "ok" on the confirmation modal.

For templates/CRM/Financial/Page/BatchTransaction.tpl, click through from "Accounting Batches" to a single batch entry (civicrm/batchtransaction). From here select "Close batch" from near the top of the page. As above the AJAX request is made when you click "ok" in the confirmation dialog. (I assume this will need the batch to be open in order to see the "Close batch" button).

[colemanw]

Thanks again @braders - this is good to merge.