Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Fix PDF Test failure on php versions 7.4 and later #21866

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

seamuslee001
Copy link
Contributor

Overview

This fixes the following test failure that is present in 5.43 and master for php versions 7.4 and later

CRM_Contribute_Form_Task_PDFTest::testSendPDF
Trying to access array offset on value of type null

/home/jenkins/bknix-max/build/build-2/web/sites/all/modules/civicrm/CRM/Contribute/Form/Task/PDF.php:183

Before

Test fails on php7.4 and later

After

Test should pass on php7.4 and later

ping @eileenmcnaughton @colemanw

@civibot
Copy link

civibot bot commented Oct 19, 2021

(Standard links)

@civibot civibot bot added the 5.43 label Oct 19, 2021
@eileenmcnaughton
Copy link
Contributor

It's a bit alarming that this change is needed tbh - but I guess until we get CI running on php 7.4 it's just gonna be this sort of stuff happening & it gets tests passing

@eileenmcnaughton eileenmcnaughton merged commit ecd3091 into civicrm:5.43 Oct 20, 2021
@eileenmcnaughton eileenmcnaughton deleted the fix_pdf_test branch October 20, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants