Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run scheduled reminder job hourly #21835

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Run scheduled reminder job hourly #21835

merged 1 commit into from
Nov 5, 2021

Conversation

wmortada
Copy link
Contributor

@wmortada wmortada commented Oct 14, 2021

As per https://lab.civicrm.org/dev/core/-/issues/2916, daily seem too infrequent for a default.

Before

The scheduled reminder job runs daily by default.

After

The scheduled reminder job runs hourly by default.

@civibot
Copy link

civibot bot commented Oct 14, 2021

(Standard links)

@civibot civibot bot added the master label Oct 14, 2021
@mlutfy
Copy link
Member

mlutfy commented Oct 14, 2021

I think these files also need to be updated:

$ grep -r "Send Scheduled Reminders" | grep -v Hourly
sql/civicrm_generated.mysql: (9,1,'Daily',NULL,NULL,'Send Scheduled Reminders','Sends out scheduled reminders via email','job','send_reminder',NULL,0),
sql/test_data_second_domain.mysql:    ( @domainID, 'Daily' ,  NULL, 'Send Scheduled Reminders',     'Sends out scheduled reminders via email',                                                     'job', 'send_reminder',           NULL, 0),

@wmortada
Copy link
Contributor Author

Thanks @mlutfy I've updated those two files as well.

@eileenmcnaughton
Copy link
Contributor

@mlutfy do you think this is ok now?

@mlutfy
Copy link
Member

mlutfy commented Nov 5, 2021

yep, thanks, merging!

@mlutfy mlutfy merged commit 1ce6ee5 into civicrm:master Nov 5, 2021
@wmortada wmortada deleted the patch-1 branch December 4, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants