Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF - Fix loop in APIv4 Entity.get to only load ad-hoc entities once #21819

Merged
merged 1 commit into from
Oct 13, 2021
Merged

REF - Fix loop in APIv4 Entity.get to only load ad-hoc entities once #21819

merged 1 commit into from
Oct 13, 2021

Conversation

colemanw
Copy link
Member

Overview

Followup to #21803 - fixes loop that was mistakenly made very inefficient

Before

Repeatedly fetch custom data and dispatch event

After

Just do it once

@civibot
Copy link

civibot bot commented Oct 13, 2021

(Standard links)

@civibot civibot bot added the 5.43 label Oct 13, 2021
@eileenmcnaughton eileenmcnaughton merged commit 19575e5 into civicrm:5.43 Oct 13, 2021
@eileenmcnaughton eileenmcnaughton deleted the APIv4EntityEvent2 branch October 13, 2021 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.43 merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colemanw @eileenmcnaughton