Repair "Norwegian Bokmål" string

[christianwach]

Overview

Fixes this issue on Lab so that "Norwegian Bokmål" renders correctly.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I guesss we should also add an upgrade script for existing dbs

[christianwach]

@eileenmcnaughton Ah, yes. Hmm, I have never looked at that process before. Any docs or a bare-bones example I could look at?

[demeritcowboy]

Also the string is in sql/civicrm_generated.mysql - you don't need to regenerate the whole file just a direct edit would be ok here.

The upgrade part is a bit tricky because (a) you don't want to update it if they've customized it, and (b) if they installed civi in non-english then the string you're looking to verify in (a) might be translated. But it doesn't have to be perfect - just don't update if no match. So I think something like

civicrm-core/CRM/Upgrade/Incremental/php/FiveTwentySix.php

Lines 106 to 115 in 5b6ef63

	$sql = CRM_Utils_SQL::interpolate('UPDATE civicrm_option_value SET label = @newLabel WHERE option_group_id = #group AND name = @name AND label IN (@oldLabels)', [
	'name' => 'nl_NL',
	'newLabel' => ts('Dutch (Netherlands)'),
	// Adding check against old label in case they've customized it, in which
	// case we don't want to overwrite that. The ts() part is tricky since
	// it depends if they installed it in English first.
	'oldLabels' => ['Dutch', ts('Dutch')],
	'group' => CRM_Core_DAO::singleValueQuery('SELECT id FROM civicrm_option_group WHERE name = "languages"'),
	]);
	CRM_Core_DAO::executeQuery($sql);

[colemanw]

@christianwach - can you take a stab at ^

[christianwach]

Sure thing... I'll try when I get a moment.

[eileenmcnaughton]

@christianwach not letting you off the hook for ^^ but I'm gonna merge this in the meantime. It does improve 'something' and it means when you put up the upgrade script it will be on the front page. Given our current PR overload I think that's a good thing