dev/core#2895 handle case ids passed via url #21801
Conversation
|
(Standard links)
|
CRM/Case/Form/Task/Email.php
Outdated
| protected function getRowsForEmails(): array { | ||
| $formattedContactDetails = []; | ||
| $contactIDSFromUrl = CRM_Utils_Request::retrieve('cid', 'CommaSeparatedIntegers', $this); | ||
| $caseIDs = explode(CRM_Utils_Request::retrieve('caseid', 'String', $this), ''); |
There was a problem hiding this comment.
This explode statement looks wrong but in any case (pun) I don't think it's worth trying to support multiple case ids in the url as per https://lab.civicrm.org/dev/core/-/issues/2463 and that other PR a week or so ago. It hasn't worked properly since at least 5.22 and after https://lab.civicrm.org/dev/core/-/issues/1750 it stopped working (by the same shop that introduced it).
There was a problem hiding this comment.
@demeritcowboy OK - if I can ignore that it gets easy
Related issue - I was thinking about removing the call to caseTokens in favour of using the payment processor token list
downside - doesn't filter custom fields by case type
upside - will show any tokens registered via token processor implementations & is more standardised
There was a problem hiding this comment.
I don't personally use it. I mean custom fields should be listed in the dropdown (as opposed to removing all custom fields from the dropdown), but I don't have a strong opinion on whether it should be filtered by case type. I'd maybe lean towards that it should stay filtered, and also if you're making a generic template you would either need to not use custom fields or create some custom tokens, so having the full list in the dropdown wouldn't necessarily help. It looks like it was part of some paid work for PDFs? https://issues.civicrm.org/jira/browse/CRM-17606
CRM/Case/Form/Task/Email.php
Outdated
| $caseID = (count($caseIDs) === 1) ? $caseIDs[0] : NULL; | ||
|
|
||
| if (!empty($contactIDSFromUrl) && !$caseID) { | ||
| $contactIDS = explode($contactIDSFromUrl, ''); |
eileenmcnaughton
force-pushed
the
case1
branch
from
cde4ccd to
82d8043
Compare
|
@demeritcowboy so I think you are saying all we need to do is this? |
eileenmcnaughton
force-pushed
the
case1
branch
from
82d8043 to
da5c41f
Compare
|
Thanks this should work for 5.43 just it gets the count of sent emails wrong in the status popup but I think is mergeable. I'll see if I can resurrect that test I closed - I probably just need to set the url param. |
|
phew - getting there! |
Overview
dev/core#2895 handle case ids passed via url
Before
After
Technical Details
Comments
@demeritcowboy does this work?