dev/core#2901 Fix send email regression

[eileenmcnaughton]

Overview

dev/core#2901 Fix send email regression

Before

Even if all the communication prefs are good and the email is valid it still gives the warning message and doesn't let you send.

Find Activities.
Select one that has a valid With Contact who isn't deceased and doesn't have email on hold etc.
From the actions dropdown choose send email
Choose With Contact.
Warning comes up and redirects you back to search. Selected contact(s) do not have a valid email address, or communication preferences specify DO NOT EMAIL, or they are deceased or Primary email address is On Hold.

After

Seems to work ok

Technical Details

One of those scary & bizarre properties...

Comments

@demeritcowboy

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Thanks will take a look. The test file is empty but that's ok it's less to look at and is a sure pass.

[eileenmcnaughton]

@demeritcowboy opps - I didn't write a test in the end because the flow was too crazy to figure out - will remove the file