Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/mail#83) message_admin - Save automatically when adding/removing drafts #21774

Merged
merged 1 commit into from
Oct 9, 2021

Conversation

totten
Copy link
Member

@totten totten commented Oct 8, 2021

Overview

When editing a message template, there are a few actions for creating, activating, and abandoning drafts. When you perform these actions, should they be buffered in the client (until you click "Save") or should they be sent immediately to the server (auto-saving the page)?

Before

"Draft"-related actions remains local the client until saving.

Screen Shot 2021-10-08 at 3 55 29 PM

After

"Draft"-related actions cause the page to save.

Screen Shot 2021-10-08 at 3 54 14 PM

Comments

For comparison, in CiviMail, these lifecycle actions (creating a draft, submitting/activating a draft, deleting a draft) have action-buttons which persist immediately. Of course, with CiviMail, the behavior is almost a necessity - its aligns with how the data is stored. For Message Templates, the data-storage is different - however, this patch should make it "feel" a bit more similar.

@civibot
Copy link

civibot bot commented Oct 8, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

As with the other PRs affecting message_admin UI I'm applying alpha/hidden extension review standards. I will test the entire release as a whole in the coming days

@eileenmcnaughton eileenmcnaughton merged commit ef5cf85 into civicrm:master Oct 9, 2021
@totten totten deleted the master-draft-save branch October 9, 2021 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants