Reference token metadata internally fix custom tokens label bug

[eileenmcnaughton]

Overview

Reference token metadata internally. This also fixes a metadata issue @magnolia61 identified where the metadata for custom fields was 'falling through' to the metadata for 'all fields' - resulting in 🏷️ variants being incorrectly added

Before

Data is stored in token metadata - it may ALSO be stored as field metadata. When we access via field metadata if will use getFields to fetch if not present

After

Referring to the token metadata array allows us to avoid an extra getfields & is a step towards only using that look up to build the token metadata

Technical Details

This references the token metadata rather than the metadata retrieved from the api
call. Since the former is cached it should save a look up -
albeit not when prefetch is happening, at this stage

Comments

@colemanw you only just merged it & I changed it :-) If this passes would be good to get it merged as #21761 builds on it

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Merging as this is rapidly evolving code and tests are passing.

[eileenmcnaughton]

thanks @colemanw - I'll do more QA during rc too & @magnolia61 has also been doing a lot of testing

[magnolia61]

@eileenmcnaughton I tested and can confirm this solves the problem. Also solved some radio yes/no fields to not show up in the list.
And also takes care of the custom_n:label field (when it should be without label) not to crash the reminder but to render blank.

[eileenmcnaughton]

@magnolia61 thanks for re-testing!