[NFC] Unit test fixes for the problem of quickform rules going missing

[demeritcowboy]

Overview

For a while now there's been a problem with certain form tests where the quickform rules go missing.

Before

Several attempts at workarounds.

After

Don't need workarounds

Technical Details

Note this line:

civicrm-core/tests/phpunit/CRM/Core/DAOConformanceTest.php

Lines 28 to 29 in 3e2bee6

	// Ugh. Need full bootstrap to enumerate classes.
	$this->setUp();

That's in a dataprovider that runs BEFORE anything even starts. So there's some time-travel mindbending going on - calling setup before setup.

It's nice to have the dataprovider but moving it to a loop inside the actual function works and avoids the problems. It looks complicated in the github view but that's the main change here.

Comments

There is still one annotation remaining that starts a test in a separate process. That's a different issue and it doesn't seem to hurt at the moment, but may need revisiting.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

I do believe you have cracked it!

[eileenmcnaughton]

And look at all those previous attempts to solve it!

[demeritcowboy]

Yay!