Standardise listTokens in email & pdf taskes #21696
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies the code to 'listtokens' across most of the pdf & email classes. The case tokens are a bit of a hold out as ideally we would have one function on CRM_Case_Form_Task which email & pdf would use but we are still getting to that point - see civicrm#21688
|
(Standard links)
|
|
Closing as this was a sub-PR and the parent has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This simplifies the code to 'listtokens' across most of the pdf & email classes.
It has the side effect of exposing domain tokens consistently (good)
Before
Variety is the spice of life
After
Bor-ring - all forms do it the same way .... almost.
Technical Details
The case tokens are a bit of a hold out as ideally we would have
one function on CRM_Case_Form_Task which email & pdf would use
but we are still getting to that point - see
#21688
Comments