[REF] Use getSubmittedValue rather than passed values #21668
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use getSubmittedValue rather than passed values
Before
When arrays of values are passed around it is
a) hard to know whether they are what was submitted or somehow altered and
b) hard to move to another place in the code (see a)
After
getSubmittedValue
used. We added this earlier this year & it's actually quite transformationalTechnical Details
Comments
tests pass so yay