Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Use getSubmittedValue rather than passed values #21668

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 29, 2021

Overview

Use getSubmittedValue rather than passed values

Before

When arrays of values are passed around it is
a) hard to know whether they are what was submitted or somehow altered and
b) hard to move to another place in the code (see a)

After

getSubmittedValue used. We added this earlier this year & it's actually quite transformational

Technical Details

Comments

tests pass so yay

@civibot
Copy link

civibot bot commented Sep 29, 2021

(Standard links)

@civibot civibot bot added the master label Sep 29, 2021
@eileenmcnaughton
Copy link
Contributor Author

test this please

@eileenmcnaughton eileenmcnaughton changed the title User getSubmittedValue rather than passed values Use getSubmittedValue rather than passed values Sep 29, 2021
@eileenmcnaughton eileenmcnaughton changed the title Use getSubmittedValue rather than passed values [REF] Use getSubmittedValue rather than passed values Sep 29, 2021
@colemanw
Copy link
Member

colemanw commented Oct 1, 2021

Tests are happy.

@colemanw colemanw merged commit 9d6c81e into civicrm:master Oct 1, 2021
@colemanw colemanw deleted the submit branch October 1, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants