Set default for civicrm_message_template.is_reserved

[eileenmcnaughton]

Overview

Set default for civicrm_message_template.is_reserved

Before

defaults to NULL

After

defaults to 0

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

Oh, so the problem you had was a record withis_reserved=NULL? Makes sense.

Agree this is sensible clarification of the default.

FWIW, in the docs MR (preview), it recommends explicitly adding both the reserved+default record. The reserved appears as a point-of-comparison, and the default one is presented for editing.

[eileenmcnaughton]

@totten yeah - I do actually have both - but only the one which IS reserved has a value

I hit something else - for some reason it's not loading my text- we can ignore that - so wrote in some html & a subject & hit save & it failed - the issue was there was no text version. I think that should be optional and it wasn't validation it failed - it was a required field 'string' in the translation code - trying to save a copy of an empty string I think

[eileenmcnaughton]

test this please