dev/core#2870 Fix upgrade error with rpow installed

[eileenmcnaughton]

Overview

dev/core#2870 Fix upgrade error with rpow installed

Before

5.43 upgrade crashes sites with rpow enabled

After

no crash

Technical Details

The method for getting the database name was not rpow friendly - happily the method that is is also less code & easier to maintain

Comments

https://github.com/totten/rpow

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[totten]

The use-case is fairly specific, and I'm inclined to trust @eileenmcnaughton's testing on whether it fixes the target problem.

I think the main question is whether this could be regressive. From reading, I'm not concerned that it's regressive. There are some circumstances (namely, pre-boot/pre-install -- when the system initialization is in a funny place) where you might prefer the static-y/global-y check over the new CRM_Core_DAO check. But this isn't that circumstance. The checkFKExists() operation is going to be used after you have a decent DB connection.

[eileenmcnaughton]

thanks @totten