Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(REF) MessageTemplate - Reverse renderTemplate()<=>sendTemplate() call #21610

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 25, 2021

Overview

Reverse Render->send to Sent->render in heavily tested MessageTemplate BAO functions

Before

Render calls send to render

After

Send calls send to render

Technical Details

We have a gazillion tests on this code ... - the diff looks bigger than it is because sometimes diffs do that

Comments

@civibot
Copy link

civibot bot commented Sep 25, 2021

(Standard links)

@civibot civibot bot added the master label Sep 25, 2021
@eileenmcnaughton eileenmcnaughton changed the title Reverse Render->send to Sent->render Reverse Render->send to Send->render Sep 25, 2021
We have a gazillion tests on this code ...
@totten totten force-pushed the rend branch 2 times, most recently from 8f6d0e0 to 507df2f Compare September 28, 2021 08:01
The prior commit had the effect of dropping any filtering that happend on `$params`.
@totten totten changed the title Reverse Render->send to Send->render (REF) MessageTemplate - Reverse renderTemplate()<=>sendTemplate() call Sep 28, 2021
@totten
Copy link
Member

totten commented Sep 28, 2021

@eileenmcnaughton woot, looks like we got it passing now.

@eileenmcnaughton
Copy link
Contributor Author

@totten cool - that will save us from hours of answering 'why does render call send' questions over the next few years

@eileenmcnaughton eileenmcnaughton merged commit 2fddef5 into civicrm:master Sep 28, 2021
@eileenmcnaughton eileenmcnaughton deleted the rend branch September 28, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants