Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial test on event tokens #21563

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Initial test on event tokens #21563

merged 2 commits into from
Sep 22, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 21, 2021 •
edited
Loading

Overview

Initial test on event tokens

Before

We can't touch event tokens until there is a test

After

Now there is a test

Technical Details

Comments

@civibot
Copy link

civibot bot commented Sep 21, 2021

(Standard links)

@civibot civibot bot added the master label Sep 21, 2021
@eileenmcnaughton eileenmcnaughton mentioned this pull request Sep 21, 2021
Merged
@eileenmcnaughton eileenmcnaughton force-pushed the ev_toke branch 3 times, most recently from 02695bb to 5d95010 Compare September 21, 2021 10:40
@eileenmcnaughton
Initial test on event tokens
f399fbd 
Note there is an issue to do with caching affecting the custom token but
it's out of scope on this test
@eileenmcnaughton
Copy link
Contributor Author

@jusfreeman FYI - but there is nothing to r-run here as it is just getting the tests in place so we know we can (mostly) avoid accidental by-product changes

@eileenmcnaughton
Test cleanup
934388b 
Fixes passing null to event create. Remove some tests duplicated by syntaxconformance
@eileenmcnaughton
Copy link
Contributor Author

Oh - that should have been @agileware-justin - merging this anyway

@eileenmcnaughton eileenmcnaughton merged commit 3ed153b into civicrm:master Sep 22, 2021
@eileenmcnaughton eileenmcnaughton deleted the ev_toke branch September 22, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
has-test master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @seamuslee001