Stop testing for gender_id output that was described as 'legacy' years ago

[eileenmcnaughton]

Overview

Stop testing for gender_id output that was described as 'legacy' years ago

Before

The widget advertises {contact.gender} but {contact.gender_id} is a hidden token. Both are non-standardness

We have test coverage locking in this non-standardness for both

After

We stop testing the non-standard hidden token & allow it to stop returning the label & revert back to the id or 'whatever' since it's not an 'official' token

Documention is here for this token changing (the change is in a follow up PR but I wanted to get this merged to expose this decision & simplify that PR but taking the decision out of it) - along with other edge case tokens being altered. By making this a 'thing' in 5.43 we can give people the notice to check & test.

Technical Details

{contact.gender_id} has not been 'advertised' in the widget for years, if ever - last commit was in 2019 it was an array formatting commit

Comments

@colemanw @seamuslee001

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).