Tpl notice fixes #21503
Merged
Tpl notice fixes #21503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
tpl
branch
from
6e59113 to
4684d50
Compare
|
Looks good |
| <td>{$row.action|replace:'xx':$row.id}</td> | ||
| <td> | ||
| {if (!empty($row.id))} | ||
| {$row.action|replace:'xx':$row.id} |
There was a problem hiding this comment.
I had left this one out of a previous PR because I don't think this replacement ever actually happens, just hadn't got around to confirming it. Not a blocker just I might end up forgetting about it if it never displays again.
There was a problem hiding this comment.
Yeah I wondered about that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Tpl notice fixes
Before
After
poof
Technical Details
Comments