Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] add test & static array to participant values tokens #21476

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[REF] add test & static array to participant values tokens

Before

No visibility into what the array returns since it relies on the mystical & insance bao 'exportFields' function

After

Hard coded list & tested

Technical Details

The badge screen is the only place in core that leverages this - it actually duplicates some of these tokens. I'm going to rationalise them in a follow up PR

Comments

@civibot
Copy link

civibot bot commented Sep 14, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 @colemanw this should be an easy merge I think - I added the test cover before the change to 'prove' it

@colemanw
Copy link
Member

Looks good.

@colemanw colemanw merged commit 76343cb into civicrm:master Sep 16, 2021
@colemanw colemanw deleted the part branch September 16, 2021 22:01
@magnolia61
Copy link
Contributor

Thank you for giving the participant tokens some love 🥰

@eileenmcnaughton
Copy link
Contributor Author

@magnolia61 I'm doing a code cleanup on the tokens in general - if you are able to make some time to test the 5.43 rc when we cut it in October it would be much appreciated as lots of stuff is being changed in token-related codeso some solid testing will be needed....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants