dev/core#2817 remove call to getTokenDetails #21475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the call to getTokenDetails as discussed on civicrm#21445 As discussed on that PR & related gitlabs I created an extension to try to allow people to have this functionality transitionally if they needed (based on copying code from 5.41 over) - but per the readme https://github.com/eileenmcnaughton/legacytokenhelper/blob/master/README.md the issues I found (under 'known issues') were enough to make me conclude no-one would actually want to install the extension to restore pre-5.43 functionality
|
(Standard links)
|
|
thanks @demeritcowboy ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#2817 remove call to getTokenDetails
Removes the call to getTokenDetails as discussed on
#21445
Before
[$contact] = CRM_Utils_Token::getTokenDetails($params,...After
poof
Technical Details
As discussed on PR #21445 & related gitlabs I
created an extension to try to allow people to have
this functionality transitionally if they needed
(based on copying code from 5.41 over) - but
per the readme https://github.com/eileenmcnaughton/legacytokenhelper/blob/master/README.md
the issues I found (under 'known issues') were enough
to make me conclude no-one would actually
want to install the extension to restore pre-5.43
functionality
Comments
@demeritcowboy After digging a bit more - per above - I feel pretty good about removing this - have added https://lab.civicrm.org/documentation/docs/sysadmin/-/merge_requests/318
Once this is merged I'll move the rest of the code from pdflettercommon to the trait