dev/core#2832 Add test for legacy membership tokens, add support for preferred tokens #21453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…preferred tokens There is only one place that calls this code. With cover of the legacy tokens I can ensure it is the same as the processor tokens. I've fixed it to support the preferred unambiguous tokens because that means that we don't have to deal with reports of them not working while calls to it are phased out of extensions. Working through that also allowed me to remove some code now
|
(Standard links)
|
| * Store membership tokens on the static _tokens array. | ||
| */ | ||
| protected static function _buildMembershipTokens() { | ||
| $key = 'membership'; |
There was a problem hiding this comment.
replaced with a fixed array
| @@ -1714,13 +1707,29 @@ public static function replaceMultipleContributionTokens(string $separator, stri | |||
| * @return string token replacement | |||
| */ | |||
| public static function getMembershipTokenReplacement($entity, $token, $membership) { | |||
| self::_buildMembershipTokens(); | |||
| $supportedTokens = [ | |||
There was a problem hiding this comment.
Confirmed that this matches the effective array here https://github.com/civicrm/civicrm-core/blob/master/CRM/Core/SelectValues.php#L526
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#2832 Add test for legacy membership tokens, add support for preferred tokens
Before
Less tests, more code, no support for preferred unambiguous tokens
{membership.status_id:label}&{membership.membership_type_id:labe}After
This is mostly about adding the tests to permit changing to the processor & ensuring no unexpected changes.
However, I've fixed the outgoing code to support the preferred unambiguous tokens.
It seems like a little extra work now but it means that we will know those tokens work consistently, even from (unsupported) outside of core calls. Also it means that if the full conversion gets too hard the existing code supports these preferred tokens
Working through that also allowed me to rdetermine the complicated code wasn't achieving anything a fixed array didn't and switching to a fixed array removed a dependency from the outgoing code to other core code.
Technical Details
There is only one place that calls this code. With cover of the legacy tokens
I can ensure it is the same as the processor tokens.
Comments