Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Add pseudo-fields for row number and current user #21435

Merged
merged 2 commits into from
Sep 16, 2021

Conversation

colemanw
Copy link
Member

Overview

Makes a couple calculated fields available for use as columns or tokens in SearchKit.

Before

No option to display current user or row number in columns or tokens

After

New columns available:
Screenshot from 2021-09-11 11-02-15

New fields also work as tokens:
Screenshot from 2021-09-11 10-59-44

@civibot
Copy link

civibot bot commented Sep 11, 2021

(Standard links)

@eileenmcnaughton
Copy link
Contributor

eileenmcnaughton commented Sep 14, 2021

Generally works but I noted
(on demo now )
http://core-21435-8bdvx.test-1.civicrm.org:8001/civicrm/search#/display/contacts/dd

  1. you can try to sort the by the pseudofield columsn - but you can't succeed

  2. in search form you can click on page 3 & row number will say 110 - but in search display & afform it will say 10

  3. if you export then the row number re-numbers from 1 (that might be by design - not sure)

image

@colemanw
Copy link
Member Author

@eileenmcnaughton I have pushed up a fix to the first problem.
The second was actually a regression and I fixed it in #21488 - it wasn't just the count that was displaying incorrectly on subsequent pages, it was everything.
The third I think we can safely ignore for now.

@eileenmcnaughton
Copy link
Contributor

ok - that seems to be working now

@eileenmcnaughton eileenmcnaughton merged commit 4da45a7 into civicrm:master Sep 16, 2021
@eileenmcnaughton eileenmcnaughton deleted the pseudoFields branch September 16, 2021 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants