Follow up on removing contributeMode from templates

[eileenmcnaughton]

Overview

Follow up on removing contributeMode from templates

Before

$contributeMode still being assigned in another place

After

poof

Technical Details

Per #21059
its a really long time since this was in the stock templates

Comments

@demeritcowboy

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

The only difficulty I'm having is that there are contributeMode's in the page templates (as opposed to message templates), and it's not always obvious where they come from. The function name has "message" in it but in civi-world it's dangerous to assume.

This one though I don't see anything that depends on the value "directIPN" anywhere, so at worst would be another smarty debug notice.

[eileenmcnaughton]

@demeritcowboy yeah - the goal has been to remove references to $contributionMode since about ... 4.6. It's not going that great