Smarty warning about missing contact subtype on New Individual

[demeritcowboy]

Overview

It's not unusual to have zero contact subtypes defined.

Before

Turn on Enable Debugging.

Notice: Trying to access array offset on value of type null in include() (line 89 of ...\templates_c\en_US%%FD\FD4\FD4493C8%%Individual.tpl.php).
Notice: Undefined index: contact_sub_type in include() (line 91 of ...\templates_c\en_US%%FD\FD4\FD4493C8%%Individual.tpl.php).
Notice: Trying to access array offset on value of type null in include() (line 91 of ...\templates_c\en_US%%FD\FD4\FD4493C8%%Individual.tpl.php).
Notice: Undefined index: prefix in include() (line 11 of ...\templates_c\en_US%%B2\B2F\B2F0EF90%%ContactReference.tpl.php).

After

Technical Details

The field gets skipped over here:

civicrm-core/CRM/Contact/Form/Contact.php

Line 775 in a77bc9d

$subtypes = CRM_Contact_BAO_Contact::buildOptions('contact_sub_type', 'create', ['contact_type' => $this->_contactType]);

And I can't see any other reason for the javascript since the field doesn't exist for it to act on.

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Hard to say how and why the code was written like that, but sometimes people do things "the hard way" due to lack of awareness of better alternatives. That's as good a theory as any.

[demeritcowboy]

It's a good theory.
I just noticed this <table> has a variable number of columns per row which might explain why it's always looked weird to me and never seems to "fit".