dev/core#2823 Move validation into validation function #21400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
force-pushed
the
val
branch
from
44accd4 to
a76754a
Compare
eileenmcnaughton
commented
Sep 8, 2021
| foreach (['name', 'module', 'entity', 'params'] as $key) { | ||
| if (empty($declare[$key])) { | ||
| $str = print_r($declare, TRUE); | ||
| return ("Managed Entity is missing field \"$key\": $str"); | ||
| return ts('Managed Entity (%1) is missing field "%2": %3', [$module, $key, $str]); |
There was a problem hiding this comment.
I think these errors are seen often enough to warrant a translation
eileenmcnaughton
force-pushed
the
val
branch
from
a76754a to
e12da84
Compare
As the code comments suggest the handling of a module being unrecognised sould be handled in the validate not the enable function
eileenmcnaughton
force-pushed
the
val
branch
from
e12da84 to
5e8660a
Compare
|
Refactoring makes sense and tests are happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#2823 Move validation into validation function
Before
The validate function has a comment about checking the module is recognised - the enable function throws an exception if it isn't
After
The validate function ... validates
Technical Details
As the code comments suggest the handling of a module being unrecognised should
be handled in the validate not the enable function
I find the moduleIndex pretty nasty - all known modules
are indexed into either the TRUE key or the FALSE
key depending on whether they are enabled or not.
I'm focussing on adding getters to access that info for now
& will later change the structure when the code is not interacting
directly with the property
Comments