Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev/core#2814 Fix activity:sendEmail follow up #21385

Merged
merged 1 commit into from
Sep 6, 2021

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Follow up fix on #21365

@demeritcowboy

@civibot
Copy link

civibot bot commented Sep 6, 2021

(Standard links)

@civibot civibot bot added the master label Sep 6, 2021
@seamuslee001
Copy link
Contributor

@eileenmcnaughton any chance of expanding the test cover to prevent further regressions?

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 Yeah - but probably not for a few days - I'd vote for merging this & then I'll try to add in when I revist to remove the calls to removeCaseTokens to avoid anyone getting confused

@seamuslee001
Copy link
Contributor

using the test in #21386 I was able to verify this fixed the problem Dave D outlined

@seamuslee001 seamuslee001 merged commit 5e458bf into civicrm:master Sep 6, 2021
@seamuslee001 seamuslee001 deleted the email_fix branch September 6, 2021 23:50
@eileenmcnaughton
Copy link
Contributor Author

Thanks @seamuslee001 appreciate that - I hope to add more tests when I convert the case tokens - although we have to work through the date issue on that first but then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants