Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't specify character set for civicrm_relationship_cache table #21382

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Sep 6, 2021

Overview

The upgrader in 5.29 specified utf8 for character set. It should not be specified as it should use the database default (eg. utf8mb4).

How did I find this? Keep finding civicrm_relationship_cache set to utf8 on client databases when everything else is utf8mb4.

Before

Hardcoded to utf8

After

Uses database default (eg. utf8mb4)

Technical Details

Comments

I don't think a new table was added to core for a long time and then this was added in 5.29. I'd like to fix the upgrader step even though it won't affect many (ie. they've probably already run the upgrade or will install new) because it leaves a bad example or how to create a new table in core.

@civibot
Copy link

civibot bot commented Sep 6, 2021

(Standard links)

@civibot civibot bot added the master label Sep 6, 2021
@eileenmcnaughton
Copy link
Contributor

@seamuslee001 this looks right to me - agree?

@seamuslee001
Copy link
Contributor

Yes I think so

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants