Don't specify character set for civicrm_relationship_cache table #21382
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The upgrader in 5.29 specified utf8 for character set. It should not be specified as it should use the database default (eg. utf8mb4).
How did I find this? Keep finding
civicrm_relationship_cache
set to utf8 on client databases when everything else is utf8mb4.Before
Hardcoded to utf8
After
Uses database default (eg. utf8mb4)
Technical Details
Comments
I don't think a new table was added to core for a long time and then this was added in 5.29. I'd like to fix the upgrader step even though it won't affect many (ie. they've probably already run the upgrade or will install new) because it leaves a bad example or how to create a new table in core.