Update use of CRM_Utils_System::setTitle() for legacycustomsearches

[mattwire]

Overview

Follows on from some work that @eileenmcnaughton started in 2019. Forms should use $this->setTitle() instead of CRM_Utils_System::setTitle() because it allows you to use $this->getTitle() on a form to get the title of the form that the user will see.

Before

Calls to CRM_Utils_System::setTitle() via child functions that are identical to parent function.

After

Calls to $this->setTitle() calls parent function directly which sets the title in the same way as CRM_Core_Form even though we don't inherit from CRM_Core_Form here.

Technical Details

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Impressive score @mattwire

This all looks sensible

[colemanw]

Nice!