dev/core#2814 Fix profile edit to use messagetemplate:render

[eileenmcnaughton]

Overview

dev/core#2814 Fix profile edit to use messagetemplate:render

Before

Weird & wonderful way of resolving the tokens, no test

After

Test, uses renderTemplate

 $url = CRM_Core_BAO_MessageTemplate::renderTemplate([
        'messageTemplate' => ['msg_text' => $this->_postURL],
        'contactId' => $this->_id,
        'disableSmarty' => TRUE,
      ])['text'];

Technical Details

If the api were merged I would have used that - but this adds the test & when can test converting
to the api when it is merged. It gets the hard lifting of this conversion out of the way

• note I put the notes below on the gitlab but thought I'd copy them here too

As of a 6 months ago, or so, we had resolved all differences between using the token processor and replaceContactTokens to ....replaceContactTokens.
We don't quite have the api yet but when complete it is pretty much a drop in replacement for renderTemplate

Calling renderTemplate directly is supported provided

1. it is only done from core and
2. there is test cover for each instance

We don't have that many places left so I'm going to push through & replace them.
The last place in core is the token processor itself. I intend to cut that dependency last & duplicate the code in some way onto the processor.
While not supported from outside of core replaceContactTokens IS called from a number of places. We are also firming up the new token api so I don't want to 'hustle' people to change their code until it's bedded in so I propose to deprecate quietly at this stage (@deprecated on the function but don't make it 'noisy' for a few more months)

Comments

https://lab.civicrm.org/dev/core/-/issues/2814

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Refactor makes sense. This simplifies code & adds test coverage.