[REF] Extract code to get the from address for a recurring contribution.

[eileenmcnaughton]

Overview

[REF] Extract code to get the from address for a recurring contribution.

Before

Long code block

After

spiffing new function

Technical Details

This makes the retrieval generally available, since is it part of the data model,
rather than tied to the form. It could possibly be a token, or at least retrievable on
the recurring edit workflow template - but that is beyond the scope of this

Note that in some cases this could result in an extra query but in others it might make the query quicker. I don't think an extra query in a form post process is a biggie (deep in the BAO it could be)

This parameter is specifically covered in the test I pre-added but I updated the test so that it was using the more 'complicted' variant - ie retrieving from a contribution page

Comments

@seamuslee001 are you able to MOP this - I think it's pretty straight forward & will make code conversations easier if we get rid of this noise

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Refactor makes sense to me.