dev/core#2732 SearchKit - Move field formatting from client-side to server-side #21320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
Formattig field values server-side allows the view values to be reused in exports. It also opens the door for more complex formatting to happen on the server, if needed.
|
I'm doing r-run on this & have logged https://lab.civicrm.org/dev/core/-/issues/2803 as an observation but not changed by this PR |
|
Another issue found in r-run - it appears to predate this change |
|
And another usability issue from this https://lab.civicrm.org/dev/core/-/issues/2805 |
|
None of the issues I found in r-run testing appear to be new. I couldn't find any breakage as a result of this PR - merging |
|
I put up documentation here https://lab.civicrm.org/documentation/docs/user-en/-/merge_requests/495 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Refactoring work toward a SearchKit direct export feature.
https://lab.civicrm.org/dev/core/-/issues/2732
Before
Field formatting (e.g. date format) done in javascript.
After
Field formatting done on the server
Technical Details
Formattig field values server-side allows the view values to be reused in exports.
It also opens the door for more complex formatting to happen on the server, if needed.
https://lab.civicrm.org/documentation/docs/user-en/-/merge_requests/495