REF Don't check if id is set in ContributionView form - it's required

[mattwire]

Overview

Following on from work by @jaapjansma around template contributions I'm looking to simplify the contribution view so it always displays "lineitems" - see https://github.com/civicrm/civicrm-core/compare/master...mattwire:contributionviewlineitems?expand=1

However, as a pre-requisite to that I found that $id is a required parameter to preProcess() but if ($id) is being used in some places in the function. This cleans that up, making it clear that $id is required and not doing additional checks to see if $id is set.

Before

Unnecessary checks. Unclear if $id is required without checking functions where it is a param.

After

$id is clearly always required.

Technical Details

Comments

Review with w=1 in URL to hide whitespace changes.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

This is not supposed to work because assign takes a key + value as params. But somehow it manages to work because most of the fields on the form come from this array. Replaced with assignVariables which is actually meant to do what it does.

[seamuslee001]

This all seems fine to me MOP

[mattwire]

Thanks @seamuslee001