SearchKit - Use a search display to display searches #21270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
CRM/Contact/DAO/SavedSearch.php
Outdated
| @@ -189,7 +189,7 @@ public static function &fields() { | |||
| 'name' => [ | |||
| 'name' => 'name', | |||
| 'type' => CRM_Utils_Type::T_STRING, | |||
| 'title' => ts('Saved Search Name'), | |||
| 'title' => ts('Name'), | |||
There was a problem hiding this comment.
I thought where we landed was that the title would assume low-context and <html<label> would assume high context - so instead of reducing the information in the title we would add a html label tag
|
This passed r-run - I'm just not sure the schema changes is what we agreed on? |
|
@colemanw this is stale - I'm assuming the dao change is now otherwise merged |
colemanw
force-pushed
the
searchKitListing
branch
from
4424f22 to
d102f83
Compare
|
Looks like my concern has been addressed - MOP |
|
Thanks @eileenmcnaughton - while re-testing this I found another bug: #21333 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This updates SearchKit to use a search display to display the list of searches.
Before
The table of saved searches was just an ad-hoc thing I wrote in Angular. It doesn't have a pager so wouldn't scale past a few hundred.
After
Now it uses a search display, which reduces code while adding a few nice features like a pager and in-place edit:
Technical Details
Most of it I was able to do with vanilla searchDisplay code. In order to render the fancy custom-coded columns like the list of Afforms, I added a new column type which lets you supply your own angular template: