Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provided standard links in ext/oauth-client/info.xml, fixed typo #21252

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

JoeMurray
Copy link
Contributor

Overview

Added standard links to info.xml. Fixed a typo.

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

@civibot
Copy link

civibot bot commented Aug 25, 2021

(Standard links)

@civibot civibot bot added the master label Aug 25, 2021
@JoeMurray JoeMurray changed the title Provided standard links in info.xml, fixed typo Provided standard links in ext/oauth-client/info.xml, fixed typo Aug 25, 2021
@colemanw
Copy link
Member

Looks good, thanks @JoeMurray

<url desc="Support">http://FIXME</url>
<url desc="Main Extension Page">https://github.com/civicrm/civicrm-core/tree/master/ext/oauth-client</url>
<url desc="Documentation">https://docs.civicrm.org/sysadmin/en/latest/setup/oauth/</url>
<url desc="Support">https://lab.civicrm.org/extensions/oauth/-/issues</url>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting that this isn't where issues are being filed. They're all in dev/core and tagged comp:oauth. (I'm not sure why that extension space exists?)

@eileenmcnaughton eileenmcnaughton merged commit 39343e9 into master Aug 25, 2021
@eileenmcnaughton eileenmcnaughton deleted the JoeMurray-patch-1 branch August 25, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants