[Ref] Copy emailcommon function back to email trait

[eileenmcnaughton]

Overview

[Ref] Copy emailcommon function back to email trait

Before

Most email functionality has been moved to the email trait but not preProcessFromAddress - the guts of this function is only used by one of the other of the functions that calls is with the tricky logic already extracted to CRM_Core_BAO_Email::getEmailSignatureDefaults so we aren't gaining from having it on the old class

After

A copy is on the emailTrait, very minimal cleanup of it so far for ease of review

Technical Details

This is part of ending the email common trait. It is currently 'shared'
with a couple of other places - but most of the functionality is
not that shared & could be easily cleaned up when separated out.

I want to create a trait for PdfTrait like the email trait so
getting the email trait better separated for that

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

unused (that's not how we roll now & would just be an enotice if there was an issue)

[eileenmcnaughton]

(afterwards)

[demeritcowboy]

I don't really understand the "before" paragraph but this seems ok.