Alternate to 20131 - Avoid crash during import for blank lines in a one-column csv file

[demeritcowboy]

Overview

Alternate to #20131

Importing a one-column csv file that has blank lines in it will crash

Before

1. Create a file with just, e.g. email, in it. It should only have one column.
2. Add one or more blank lines at the end.
3. Go to contact import and import it.
4. Crash with TypeError: Argument 1 passed to CRM_Import_DataSource_CSV::trimNonBreakingSpaces() must be of the type string, null given in CRM_Import_DataSource_CSV::trimNonBreakingSpaces() (line 259 of .../CRM/Import/DataSource/CSV.php)
5. Unit test fails with same error.

After

Blank line is skipped. Test passes.

Technical Details

A blank line is read by fgetcsv as array(0 => NULL). When there's more than one expected column this gets skipped by some column-count checking already in the import code. When there's only one column, this ends up calling a function that's not expecting null. If the line is blank, don't even need to bother.

Comments

Has test.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Ohh nice - that will also help if we want to do the 'better' fix & switch to reading the csv using the Reader package because the test is there now

[eileenmcnaughton]

@mlutfy looks good to me - work for you?

[mlutfy]

Looks good, thank you!

I tested a few variations, including:

• One column, with some empty lines at the middle of the file, or at the end of the file
• Two columns, with the above variations
• Lines that had only spaces

[demeritcowboy]

Thanks!

[agileware-justin]

IMHO this should be backported and released sooner rather than later.