Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] CRM_Utils_SystemTest - Call to Uri->withPath() using deprecated format #21215

Merged
merged 1 commit into from
Aug 22, 2021

Conversation

demeritcowboy
Copy link
Contributor

Overview

Addresses test fails in #21064.

Before

CRM_Utils_SystemTest::testAlterExternUrlHook with data set 0 ('extern/url', array('extern/url', 'u=1&qid=1'))
Exception: The path of a URI with an authority must start with a slash "/" or be empty. Automagically fixing the URI by adding a leading slash to the path is deprecated since version 1.4 and will throw an exception instead.

CRM_Utils_SystemTest::testAlterExternUrlHook with data set 1 ('extern/open', array('extern/open', 'q=1'))
Exception: The path of a URI with an authority must start with a slash "/" or be empty. Automagically fixing the URI by adding a leading slash to the path is deprecated since version 1.4 and will throw an exception instead.

After

Technical Details

Guzzle uses the same "technique" (I'm trying to use a nice word) as drupal 8 that was the reason we didn't see any of the deprecations, even in logs on dev sites, until people started using drupal 9 and it hard-crashed. You only see these if you're using a special error handler: https://github.com/guzzle/psr7/blob/1.6.1/src/Uri.php#L751

Comments

@civibot
Copy link

civibot bot commented Aug 22, 2021

(Standard links)

@civibot civibot bot added the master label Aug 22, 2021
@seamuslee001
Copy link
Contributor

This seems fine to me

@seamuslee001 seamuslee001 merged commit e443072 into civicrm:master Aug 22, 2021
@demeritcowboy demeritcowboy deleted the alterExtern branch August 23, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants