[NFC] CRM_Utils_SystemTest - Call to Uri->withPath() using deprecated format #21215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Addresses test fails in #21064.
Before
CRM_Utils_SystemTest::testAlterExternUrlHook with data set 0 ('extern/url', array('extern/url', 'u=1&qid=1'))
Exception: The path of a URI with an authority must start with a slash "/" or be empty. Automagically fixing the URI by adding a leading slash to the path is deprecated since version 1.4 and will throw an exception instead.
CRM_Utils_SystemTest::testAlterExternUrlHook with data set 1 ('extern/open', array('extern/open', 'q=1'))
Exception: The path of a URI with an authority must start with a slash "/" or be empty. Automagically fixing the URI by adding a leading slash to the path is deprecated since version 1.4 and will throw an exception instead.
After
Technical Details
Guzzle uses the same "technique" (I'm trying to use a nice word) as drupal 8 that was the reason we didn't see any of the deprecations, even in logs on dev sites, until people started using drupal 9 and it hard-crashed. You only see these if you're using a special error handler: https://github.com/guzzle/psr7/blob/1.6.1/src/Uri.php#L751
Comments