Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRM_Queue_Service - Use ?? instead of error-supression operator #21207

Merged
merged 1 commit into from
Aug 21, 2021

Conversation

demeritcowboy
Copy link
Contributor

Overview

Similar to #21206

Addresses test fails in #21064:

not ok 2343 - Error: CRM_Queue_Queue_SqlTest::testPriorities with data set #0 (array('Sql', 'test-queue'))
not ok 2344 - Error: CRM_Queue_QueueTest::testBasicUsage with data set #0 (array('Sql', 'test-queue'))
not ok 2345 - Error: CRM_Queue_QueueTest::testBasicUsage with data set #1 (array('Memory', 'test-queue'))
not ok 2346 - Error: CRM_Queue_QueueTest::testManualRelease with data set #0 (array('Sql', 'test-queue'))
not ok 2347 - Error: CRM_Queue_QueueTest::testManualRelease with data set #1 (array('Memory', 'test-queue'))
not ok 2348 - Error: CRM_Queue_QueueTest::testTimeoutRelease with data set #0 (array('Sql', 'test-queue'))
not ok 2349 - Error: CRM_Queue_QueueTest::testTimeoutRelease with data set #1 (array('Memory', 'test-queue'))
not ok 2350 - Error: CRM_Queue_QueueTest::testStealItem with data set #0 (array('Sql', 'test-queue'))
not ok 2351 - Error: CRM_Queue_QueueTest::testStealItem with data set #1 (array('Memory', 'test-queue'))
not ok 2352 - Error: CRM_Queue_QueueTest::testCreateResetTrue with data set #0 (array('Sql', 'test-queue'))
not ok 2353 - Error: CRM_Queue_QueueTest::testCreateResetTrue with data set #1 (array('Memory', 'test-queue'))
not ok 2354 - Error: CRM_Queue_QueueTest::testCreateResetFalse with data set #0 (array('Sql', 'test-queue'))
not ok 2355 - Error: CRM_Queue_QueueTest::testCreateResetFalse with data set #1 (array('Memory', 'test-queue'))
not ok 2356 - Error: CRM_Queue_QueueTest::testLoad with data set #0 (array('Sql', 'test-queue'))
not ok 2357 - Error: CRM_Queue_QueueTest::testLoad with data set #1 (array('Memory', 'test-queue'))
not ok 2358 - Error: CRM_Queue_RunnerTest::testRunAllNormal
not ok 2359 - Error: CRM_Queue_RunnerTest::testRunAll_AddMore
not ok 2360 - Error: CRM_Queue_RunnerTest::testRunAll_Continue_Exception
not ok 2361 - Error: CRM_Queue_RunnerTest::testRunAll_Abort_Exception
not ok 2362 - Error: CRM_Queue_RunnerTest::testRunAll_Abort_False

@civibot
Copy link

civibot bot commented Aug 21, 2021

(Standard links)

@civibot civibot bot added the master label Aug 21, 2021
@colemanw colemanw merged commit 3d8b299 into civicrm:master Aug 21, 2021
@demeritcowboy demeritcowboy deleted the queueservice branch August 21, 2021 19:49
@demeritcowboy
Copy link
Contributor Author

Thanks @colemanw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants